xinrong-meng commented on code in PR #39753:
URL: https://github.com/apache/spark/pull/39753#discussion_r1090101065
##########
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -297,7 +297,7 @@ message Expression {
}
}
-message ScalarInlineUserDefinedFunction {
+message CommonUserDefinedFunction {
Review Comment:
1. Series-to-Scalar Pandas UDFs `groupby(..).agg(..)` should be able to
share the same message, so I suggested removing the `Scalar` piece.
2. As for the `Inline` piece, I was thinking we were about to make both
registered UDF and unregistered(inline) UDF share the same message so I
proposed to remove it.
`CommonInlineUserDefinedFunction` sounds fine. I am just wondering if my
understanding of point 2. is correct. @grundprinzip @hvanhovell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
