amaliujia commented on code in PR #40013:
URL: https://github.com/apache/spark/pull/40013#discussion_r1117739382
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -1346,16 +1346,16 @@ class SparkConnectPlanner(val session: SparkSession) {
}
private def transformDrop(rel: proto.Drop): LogicalPlan = {
- assert(rel.getColsCount > 0, s"cols must contains at least 1 item!")
-
- val cols = rel.getColsList.asScala.toArray.map { expr =>
- Column(transformExpression(expr))
+ var output = Dataset.ofRows(session, transformRelation(rel.getInput))
+ if (rel.getColumnsCount > 0) {
+ val cols = rel.getColumnsList.asScala.toArray.map(expr =>
Column(transformExpression(expr)))
Review Comment:
Nit: do you need `toArray` to apply `map`?
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/dsl/package.scala:
##########
@@ -703,21 +703,13 @@ package object dsl {
def drop(columns: String*): Relation = {
assert(columns.nonEmpty)
- val cols = columns.map(col =>
- Expression.newBuilder
- .setUnresolvedAttribute(
- Expression.UnresolvedAttribute.newBuilder
- .setUnparsedIdentifier(col)
- .build())
- .build())
-
Relation
.newBuilder()
.setDrop(
Drop
.newBuilder()
.setInput(logicalPlan)
- .addAllCols(cols.asJava)
+ .addAllColumnNames(columns.toSeq.asJava)
Review Comment:
maybe also add a `def drop(cols: Column*)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
