zhengruifeng commented on code in PR #40013:
URL: https://github.com/apache/spark/pull/40013#discussion_r1118211205
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -1346,16 +1346,16 @@ class SparkConnectPlanner(val session: SparkSession) {
}
private def transformDrop(rel: proto.Drop): LogicalPlan = {
- assert(rel.getColsCount > 0, s"cols must contains at least 1 item!")
-
- val cols = rel.getColsList.asScala.toArray.map { expr =>
- Column(transformExpression(expr))
+ var output = Dataset.ofRows(session, transformRelation(rel.getInput))
+ if (rel.getColumnsCount > 0) {
+ val cols = rel.getColumnsList.asScala.toArray.map(expr =>
Column(transformExpression(expr)))
Review Comment:
we use `asScala.toSeq` in many places, IIRC that is for scala 2.13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
