wangyum commented on code in PR #40268: URL: https://github.com/apache/spark/pull/40268#discussion_r1127193046
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala: ########## @@ -138,56 +136,53 @@ object ConstantPropagation extends Rule[LogicalPlan] { * case of `WHERE e`, null result of expression `e` means the same as if it * resulted false * @return A tuple including: - * 1. Option[Expression]: optional changed condition after traversal + * 1. Expression: optional changed condition after traversal Review Comment: Remove the `optional`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org