LuciferYang commented on code in PR #40349:
URL: https://github.com/apache/spark/pull/40349#discussion_r1133074749
##########
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -192,8 +192,8 @@ message Expression {
}
message Array {
- DataType elementType = 1;
- repeated Literal element = 2;
+ DataType element_type = 1;
+ repeated Literal elements = 2;
Review Comment:
When I first defined it, I confirmed to @hvanhovell that it should be
`element` rather than `elements` , so I defined it as `element`.
https://github.com/apache/spark/pull/40218#discussion_r1125231861
At the same time, I found that we sometimes use the singular and sometimes
the plural in the definition of the `repeated` field.
https://github.com/apache/spark/blob/79b5abed8bdcd5f9657b4bcff2c5ea0c767d0bf6/connector/connect/common/src/main/protobuf/spark/connect/expressions.proto#L62-L65
https://github.com/apache/spark/blob/79b5abed8bdcd5f9657b4bcff2c5ea0c767d0bf6/connector/connect/common/src/main/protobuf/spark/connect/expressions.proto#L288
I think we should have a unified rule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
