MaxGekk commented on code in PR #40508:
URL: https://github.com/apache/spark/pull/40508#discussion_r1143607484
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -213,7 +213,9 @@ class SparkSession private[sql] (
* @param sqlText
* A SQL statement with named parameters to execute.
* @param args
- * A map of parameter names to literal values.
+ * A map of parameter names to string values that are parsed as SQL
literal expressions.
Review Comment:
> This means you're interpreting the input, am I mistaken?
For the "interpreting" word means execute the SQL text and produce a date,
but we just try to convert the input text to a literal. Roughly speaking,
switching by branches to parse the input. Don't think that it can be considered
as interpretation (or evaluation, execution and so on).
> The core part is that users of the API will see that it supports parameter
substitution and will believe it provides the same guarantees of fixed literals
...
It provides, we checks that all args are literals but arbitrary expressions,
see
https://github.com/apache/spark/blob/f8966e7eee1d7f2db7b376d557d5ff6658c80653/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/parameters.scala#L92
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
