hvanhovell commented on code in PR #40467:
URL: https://github.com/apache/spark/pull/40467#discussion_r1144196759
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Column.scala:
##########
@@ -1211,13 +1211,11 @@ class Column private[sql] (private[sql] val expr:
proto.Expression) extends Logg
* @group df_ops
* @since 3.4.0
*/
- def explain(extended: Boolean): Unit = {
+ def explain(extended: Boolean)(implicit spark: SparkSession): Unit = {
Review Comment:
@beliefer no we can't be fully consistent with SQL. We are already deviating
from what the original implementation does when you set `extended = true`. I
just want something that is more readable.
As for the implementation. The catalyst dependency is going away. Just
create a bit of tree traversal logic that nicely renders the expression tree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
