srielau commented on code in PR #41007:
URL: https://github.com/apache/spark/pull/41007#discussion_r1206061583
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -2130,8 +2176,11 @@ class AstBuilder extends
SqlBaseParserBaseVisitor[AnyRef] with SQLConfHelper wit
val filter = Option(ctx.where).map(expression(_))
val ignoreNulls =
Option(ctx.nullsOption).map(_.getType ==
SqlBaseParser.IGNORE).getOrElse(false)
- val function = UnresolvedFunction(
- getFunctionMultiparts(ctx.functionName), arguments, isDistinct, filter,
ignoreNulls)
+ val function = Option(ctx.functionName.expression()).map(p =>
+ UnresolvedFunctionIdentifierClause(expression(p),
Review Comment:
So one problem is the identifiers are different. multipartIdentifier has
this extra stuff to catch '-' "errorCapturingIdentifier".
I think I'll leave it as is. We re approaching the part where the perfect
becomes the enemy of the good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
