vicennial commented on code in PR #41357:
URL: https://github.com/apache/spark/pull/41357#discussion_r1210431327
##########
python/pyspark/sql/tests/connect/client/test_artifact.py:
##########
@@ -271,6 +271,21 @@ def func(x):
self.spark.addArtifacts(f"{archive_path}.zip#my_files",
archive=True)
self.assertEqual(self.spark.range(1).select(func("id")).first()[0], "hello
world!")
+ def test_copy_from_local_to_FS(self):
Review Comment:
Please add a server/scala-side test as well in `ArtifactManagerSuite`
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectAddArtifactsHandler.scala:
##########
@@ -89,6 +92,28 @@ class SparkConnectAddArtifactsHandler(val responseObserver:
StreamObserver[AddAr
artifactManager.addArtifact(holder, artifact.path, artifact.stagedPath,
artifact.fragment)
}
+ protected def uploadStagedArtifactToFS(artifact: StagedArtifact): Unit = {
Review Comment:
Could we move this logic inside of `SparkConnectArtifactManager#AddArtifact`
too unless there's a specific reason it needs to be here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
