HyukjinKwon commented on code in PR #41357:
URL: https://github.com/apache/spark/pull/41357#discussion_r1212527198
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/artifact/SparkConnectArtifactManager.scala:
##########
@@ -157,10 +159,34 @@ class SparkConnectArtifactManager private[connect] {
}
}
}
+
+ private[connect] def uploadArtifactToFs(
+ sessionHolder: SessionHolder,
+ remoteRelativePath: Path,
+ serverLocalStagingPath: Path): Unit = {
+ val hadoopConf = sessionHolder.session.sparkContext.hadoopConfiguration
+ assert(remoteRelativePath.startsWith(
+ SparkConnectArtifactManager.forwardToFSPrefix + File.separator)
Review Comment:
I am fine with this but one thing is that now here we pass an absolute path
with the prefix. Except here, all other places pass a relative path around. Is
that fine, @hvanhovell and @vicennial?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
