WeichenXu123 commented on code in PR #41357:
URL: https://github.com/apache/spark/pull/41357#discussion_r1212562805
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectAddArtifactsHandler.scala:
##########
@@ -100,7 +100,15 @@ class SparkConnectAddArtifactsHandler(val
responseObserver: StreamObserver[AddAr
// We do not store artifacts that fail the CRC. The failure is reported
in the artifact
// summary and it is up to the client to decide whether to retry sending
the artifact.
if (artifact.getCrcStatus.contains(true)) {
- addStagedArtifactToArtifactManager(artifact)
+ if (artifact.path.startsWith(
Review Comment:
The goal for artifact with `forward_to_fs/{dest_fs_path}` path is just to
upload file to cloud storage. Do we still need add the artifact file to
artifact manager ?
If you want , I can add it, it is simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
