vinodkc commented on code in PR #41746:
URL: https://github.com/apache/spark/pull/41746#discussion_r1248015707


##########
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedClusterMessage.scala:
##########
@@ -49,6 +49,10 @@ private[spark] object CoarseGrainedClusterMessages {
   case class KillExecutorsOnHost(host: String)
     extends CoarseGrainedClusterMessage
 
+  case class RefreshExecutors(msg: Map[String, String]) extends 
CoarseGrainedClusterMessage
+
+  case class RefreshExecutor(msg: Map[String, String]) extends 
CoarseGrainedClusterMessage

Review Comment:
   I gave a generic name to this message as this can hold a map of message 
values and in the future,  this can be reused,  if any other message needs to 
be passed to the executor. 
   
    If that is not required, I can change this to a specific message name. 
   eg: `UpdateExecutorsLogLevel(msg: String)`  & `UpdateExecutorLogLevel(msg: 
String)`
       OR 
   `RefreshExecutorsLogLevel(msg: String)` & `RefreshExecutorLogLevel(msg: 
String)`
   
   Please give your suggestions 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to