juliuszsompolski commented on PR #41443: URL: https://github.com/apache/spark/pull/41443#issuecomment-1636528999
@rangadi further about postFinished in command: I chatted with @jdesjean and he has a point that `Commands` are very free form, and if we move the postFinished one level up, then that could prevent a (maybe future) Command that needs to do postFinished at a custom time from doing it... This is already a bit of rough edge in handlePluginCommand, which is a black box inside. Maybe a ExecuteEventsManager could handle that postFinished is called only once? Then commands that need it could call it themselves, otherwise it will fall through to a call one level up? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
