ramesh-muthusamy commented on code in PR #42416:
URL: https://github.com/apache/spark/pull/42416#discussion_r1289239353
##########
core/src/main/scala/org/apache/spark/metrics/sink/StatsdSink.scala:
##########
@@ -43,6 +44,8 @@ private[spark] class StatsdSink(
val property: Properties, val registry: MetricRegistry) extends Sink with
Logging {
import StatsdSink._
+ def propertyToOption(prop: String): Option[String] =
Option(property.getProperty(prop))
Review Comment:
yes makes sense
##########
core/src/main/scala/org/apache/spark/metrics/sink/StatsdSink.scala:
##########
@@ -53,9 +56,18 @@ private[spark] class StatsdSink(
val prefix = property.getProperty(STATSD_KEY_PREFIX, STATSD_DEFAULT_PREFIX)
+ val filter = propertyToOption(STATSD_KEY_REGEX) match {
Review Comment:
agreed, updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
