HyukjinKwon commented on code in PR #44233:
URL: https://github.com/apache/spark/pull/44233#discussion_r1419780691
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceManager.scala:
##########
@@ -81,3 +93,60 @@ class DataSourceManager extends Logging {
manager
}
}
+
+/**
+ * Data Source V2 wrapper for Python Data Source.
+ */
+class PythonTableProvider(shortName: String) extends TableProvider {
+ private var sourceDataFrame: DataFrame = _
+
+ private def getOrCreateSourceDataFrame(
+ options: CaseInsensitiveStringMap, maybeSchema: Option[StructType]):
DataFrame = {
+ if (sourceDataFrame != null) return sourceDataFrame
+ // TODO(SPARK-45600): should be session-based.
Review Comment:
I think so. The thing is that we should take a look into session
inheritance, testcase, etc. So I leave this as a todo for now.
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceManager.scala:
##########
@@ -81,3 +93,60 @@ class DataSourceManager extends Logging {
manager
}
}
+
+/**
+ * Data Source V2 wrapper for Python Data Source.
+ */
+class PythonTableProvider(shortName: String) extends TableProvider {
+ private var sourceDataFrame: DataFrame = _
+
+ private def getOrCreateSourceDataFrame(
+ options: CaseInsensitiveStringMap, maybeSchema: Option[StructType]):
DataFrame = {
+ if (sourceDataFrame != null) return sourceDataFrame
+ // TODO(SPARK-45600): should be session-based.
Review Comment:
For basic support, I think so. The thing is that we should take a look into
session inheritance, testcase, etc. So I leave this as a todo for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
