zhengchenyu commented on PR #44512: URL: https://github.com/apache/spark/pull/44512#issuecomment-1874801219
> It looks like `ExternalAppendOnlyMap` uses the key for combine: > > ``` > dep.aggregator.get.combineCombinersByKey(combinedKeyValuesIterator, context) > ``` > > but `ExternalSorter` uses partition id: > > ``` > map.changeValue((actualPartitioner.getPartition(kv._1), kv._1), update) > ``` > > Do you think this would lead to the different result? @Ngone51 It seems that the key for combine is Tuple2(partitionid, key). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
