ueshin commented on PR #46140: URL: https://github.com/apache/spark/pull/46140#issuecomment-2073342960
We may want to rather fix the arguments of `apply` function to be consistent with the usage of them and with the other similar functions: https://github.com/apache/spark/blob/2a64b706135a54e177ca2e5300ccec15c4dae8bb/connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/ExecuteHolder.scala#L296-L304 https://github.com/apache/spark/blob/2a64b706135a54e177ca2e5300ccec15c4dae8bb/connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/ExecuteHolder.scala#L312-L321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
