gengliangwang commented on code in PR #46267:
URL: https://github.com/apache/spark/pull/46267#discussion_r1591513685
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -1700,6 +1700,21 @@ object SQLConf {
.booleanConf
.createWithDefault(true)
+ val VIEW_SCHEMA_BINDING = buildConf("spark.sql.defaultViewSchemaBinding")
+ .doc("Control the default behavior of views when the underlying schema
changes. " +
+ "Valid values are: " +
+ "'BINDING': Safe casts only. " +
+ "'COMPENSATION': Any supported casts. " +
+ "'TYPE EVOLUTION': Adopt type changes." +
+ "'EVOLUTION': Adopt names, types and arity." +
+ "'UNSUPPORTED': Disable the feature.")
+ .version("4.0.0")
+ .stringConf
+ .transform(_.toUpperCase(Locale.ROOT))
+ .checkValues(Set("BINDING", "COMPENSATION", "TYPE EVOLUTION", "EVOLUTION",
"UNSUPPORTED"))
Review Comment:
Let's rename `TYPE EVOLUTION` to `TYPE_EVOLUTION`, so that it is consistent
with other values such as `CodegenObjectFactoryMode`
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -1700,6 +1700,21 @@ object SQLConf {
.booleanConf
.createWithDefault(true)
+ val VIEW_SCHEMA_BINDING = buildConf("spark.sql.defaultViewSchemaBinding")
+ .doc("Control the default behavior of views when the underlying schema
changes. " +
+ "Valid values are: " +
+ "'BINDING': Safe casts only. " +
+ "'COMPENSATION': Any supported casts. " +
+ "'TYPE EVOLUTION': Adopt type changes." +
+ "'EVOLUTION': Adopt names, types and arity." +
+ "'UNSUPPORTED': Disable the feature.")
+ .version("4.0.0")
+ .stringConf
+ .transform(_.toUpperCase(Locale.ROOT))
+ .checkValues(Set("BINDING", "COMPENSATION", "TYPE EVOLUTION", "EVOLUTION",
"UNSUPPORTED"))
Review Comment:
Let's rename `TYPE EVOLUTION` to `TYPE_EVOLUTION`, so that it is consistent
with other values such as the values of `CodegenObjectFactoryMode`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
