cloud-fan commented on code in PR #46267:
URL: https://github.com/apache/spark/pull/46267#discussion_r1595515280
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala:
##########
@@ -437,6 +493,21 @@ object ViewHelper extends SQLConfHelper with Logging {
}
}
+ /**
+ * Convert the viewSchemaMode to `properties`.
+ * If the mode is UNSUPPORTED do not store anything for backward
compatibility.
+ */
+ private def viewSchemaModeToProps(viewSchemaMode: ViewSchemaMode):
Map[String, String] = {
+ if (viewSchemaMode == SchemaUnsupported) {
+ Map.empty
+ } else {
+ val modeNameJson = JString(viewSchemaMode.toString)
Review Comment:
why do we use JSON format here? The mode name is just a simple string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
