vladimirg-db commented on code in PR #46500:
URL: https://github.com/apache/spark/pull/46500#discussion_r1595606748
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/UnivocityParser.scala:
##########
@@ -316,7 +316,7 @@ class UnivocityParser(
throw BadRecordException(
() => getCurrentInput,
() => Array.empty,
- QueryExecutionErrors.malformedCSVRecordError(""))
+ MalformedCSVRecordException(""))
Review Comment:
Do you mean, to use some other exception _in place_ of `BadRecordException`
between the `UnivocityParser` and `FailureSafeParser`? Looks like a cleaner
idea! But it seems that in that case we're gonna end up with two similar
mechanisms for the same thing. And eventual refactoring for this issue does not
seem easy, considering how extensively the parsers and `BadRecordException` are
used in the codebase...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
