neilramaswamy commented on PR #48066: URL: https://github.com/apache/spark/pull/48066#issuecomment-2345425741
Yeah, sorry, I discussed with anishshri-db (not tagging) yesterday about this and while he initially agreed (just like your original comment, haha), he then later had the same realization. I think the confusion is that the reader for a given `batchId` doesn't actually return the metadata for `batchId`—it returns the metadata _before_ `batchId`. And the reader has the additional constraint that the offset for `batchId` must be present. I think, if anything, a comment should be added to this class. But otherwise, this is a non-issue, so I'm going to close it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
