mihailom-db commented on code in PR #48087:
URL: https://github.com/apache/spark/pull/48087#discussion_r1758245221
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala:
##########
@@ -1158,6 +1158,7 @@ object TableFunctionRegistry {
generator[PosExplode]("posexplode"),
generator[PosExplode]("posexplode_outer", outer = true),
generator[Stack]("stack"),
+ generator[AllCollations]("all_collations"),
Review Comment:
nit: To me this sounds weird. We suggest that there might exist collations
for some other type, for keywords it is more likely to have other keywords
(python, scala ...) @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
