MaxGekk commented on code in PR #49850:
URL: https://github.com/apache/spark/pull/49850#discussion_r1946870721


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/ExecuteImmediateEndToEndSuite.scala:
##########
@@ -36,4 +36,16 @@ class ExecuteImmediateEndToEndSuite extends QueryTest with 
SharedSparkSession {
       spark.sql("DROP TEMPORARY VARIABLE IF EXISTS parm;")
     }
   }
+
+  test("SQL Scripting not supported inside EXECUTE IMMEDIATE") {
+    withSQLConf("spark.sql.scripting.enabled" -> "true") {

Review Comment:
   Could you use `SQLConf.SQL_SCRIPTING_ENABLED.key`



##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala:
##########
@@ -917,6 +917,22 @@ class AnalysisErrorSuite extends AnalysisTest with 
DataTypeErrorsBase {
       ))
   }
 
+  test("EXEC IMMEDIATE - SQL Script as sqlString parameter") {

Review Comment:
   You can remove this duplicate test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to