Github user hhbyyh commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9520#discussion_r48692582
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala 
---
    @@ -879,6 +879,7 @@ object Matrices {
           case dm: BDM[Double] =>
             new DenseMatrix(dm.rows, dm.cols, dm.data, dm.isTranspose)
           case sm: BSM[Double] =>
    +        sm.compact()
    --- End diff --
    
    I'm not sure if this would be regarded as an error for Breeze, since they 
did provide a compact function. I'll try to check with Breeze.
    
    Close the PR for now. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to