Github user mpjlu commented on a diff in the pull request:
https://github.com/apache/spark/pull/15058#discussion_r78360606
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/BinaryClassificationMetrics.scala
---
@@ -43,10 +43,13 @@ import org.apache.spark.sql.DataFrame
@Since("1.0.0")
class BinaryClassificationMetrics @Since("1.3.0") (
@Since("1.3.0") val scoreAndLabels: RDD[(Double, Double)],
- @Since("1.3.0") val numBins: Int) extends Logging {
+ @Since("1.3.0") var numBins: Int) extends Logging {
--- End diff --
hi @srowen , can we use a simple way to add the setBins method. Seems add
a setBins method is useful.
Just as the testSuite in this PR shows. If the user wants to test different
numBins.
Create one object, just call setBins, he can easily get different results.
How about change a way to implement setBins?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
