Github user clockfly commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15099#discussion_r79124795
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
 ---
    @@ -325,6 +325,21 @@ class SessionCatalog(
         new Path(new Path(dbLocation), 
formatTableName(tableIdent.table)).toString
       }
     
    +  // ----------------------------------------------
    +  // | Methods that interact with temp views only |
    +  // ----------------------------------------------
    +
    +  /**
    +   * Return a temporary view exactly as it was stored.
    +   */
    +  def getTempView(name: String): Option[LogicalPlan] = synchronized {
    --- End diff --
    
    In the same file, there are also interfaces like isTemporaryTable, 
tableExists, refreshTable, clearTempTables, which can accept a temporary view, 
but using the name "table" instead of "view"
    
    I am not sure introducing getTempView and dropTempView will make the class 
SessionCatalog's interface simpler or more complicated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to