Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15105#discussion_r79139237
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala 
---
    @@ -227,7 +227,7 @@ class Word2VecModel private[ml] (
        */
       @Since("1.5.0")
       def findSynonyms(word: String, num: Int): DataFrame = {
    -    findSynonyms(wordVectors.transform(word), num)
    +    findSynonyms(wordVectors.transform(word), num, Some(word))
    --- End diff --
    
    I think you don't need to or want to change this file or the wrapper class 
below. They can continue to plumb through the API calls as before because in 
the underlying class you handle both cases. You might update docs in these 
classes, however, to match your change to the .mllib class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to