Github user skambha commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13822#discussion_r79265007
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala 
---
    @@ -595,6 +595,19 @@ class HiveDDLSuite
         }
       }
     
    +  test("test show partitions") {
    +    val message = intercept[AnalysisException] {
    +      sql("SHOW PARTITIONS default.nonexistentTable")
    +    }.getMessage
    +    assert(message.contains("Table does not exist"))
    +
    +    withTable("t1") {
    +      sql("CREATE TABLE t1 (key STRING, value STRING) PARTITIONED BY (ds 
STRING)")
    +      sql("ALTER TABLE t1 ADD PARTITION (ds = '1')")
    +      assert(sql(" SHOW PARTITIONS t1").schema.getFieldIndex("partition") 
== Some(0))
    --- End diff --
    
    My original reasoning for adding this test was  to exercise the code change 
that makes the output attribute reference name for SHOW PARTITIONS command to 
be ‘partition’.  This test covers this scenario.    Without the fix, it was 
‘result’.  With the fix it is ‘partition’.
    
    But it turns out another PR already made the code change for it. But no 
tests were added in that pr.  So I have kept this as a separate test for now.  
    
    If you prefer we do not need to have this test, we can remove it.   


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to