Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15051#discussion_r79297229
  
    --- Diff: R/pkg/R/mllib.R ---
    @@ -694,8 +694,14 @@ setMethod("predict", signature(object = "KMeansModel"),
     #' }
     #' @note spark.mlp since 2.1.0
     setMethod("spark.mlp", signature(data = "SparkDataFrame"),
    -          function(data, blockSize = 128, layers = c(3, 5, 2), solver = 
"l-bfgs", maxIter = 100,
    -                   tol = 0.5, stepSize = 1, seed = 1) {
    +          function(data, layers, blockSize = 128, solver = "l-bfgs", 
maxIter = 100,
    +                   tol = 1E-6, stepSize = 0.03, seed = 0x7FFFFFFF) {
    +            if (length(layers) <= 1) {
    +              stop("layers vector require length > 0.")
    +            }
    +            if (any(sapply(layers, function(e) !is.numeric(e)))) {
    --- End diff --
    
    You can use `numToInt` from 
https://github.com/apache/spark/blob/master/R/pkg/R/utils.R#L368 -- It'll print 
a warning if its not an integer


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to