Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15139#discussion_r79303509
  
    --- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
    @@ -761,27 +761,13 @@ test_that("spark.kstest", {
       expect_equal(stats$p.value, rStats$p.value, tolerance = 1e-4)
       expect_equal(stats$statistic, unname(rStats$statistic), tolerance = 1e-4)
     
    -  printStr <- print.summary.KSTest(testResult)
    --- End diff --
    
    The output is relevant to the implementation of 
```KolmogorovSmirnovTestResult.toString```, if it was updated, this test will 
be broken which is not reasonable IMO. We have already checked the summary 
output value in unit test, I think it's not necessary to check another kinds of 
these value again. And I believe we will add more summary information later, 
which will require updating the expected printing summary again and again. In 
all other ML wrappers, we did not check print summary. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to