Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14803#discussion_r79488089
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
 ---
    @@ -197,10 +197,13 @@ case class DataSource(
             SparkHadoopUtil.get.globPathIfNecessary(qualified)
           }.toArray
           val fileCatalog = new ListingFileCatalog(sparkSession, globbedPaths, 
options, None)
    +      val partitionCols = 
fileCatalog.partitionSpec().partitionColumns.fields
           format.inferSchema(
             sparkSession,
             caseInsensitiveOptions,
    -        fileCatalog.allFiles())
    +        fileCatalog.allFiles()).map { inferredSchema =>
    --- End diff --
    
    +1
    
    I think this is much easier to understand as:
    
    ```scala
    val partitionCols = fileCatalog.partitionSpec().partitionColumns.fields
    val inferred = format.inferSchema(
      sparkSession,
      caseInsensitiveOptions,
      fileCatalog.allFiles())
    
    inferred.map { inferredSchema =>
      StructType(inferredSchema ++ partitionCols)
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to