Github user dbtsai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14834#discussion_r79509539
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
 ---
    @@ -430,8 +431,9 @@ class LogisticRegressionWithLBFGS
             lr.setStandardization(useFeatureScaling)
             if (userSuppliedWeights) {
               val uid = Identifiable.randomUID("logreg-static")
    -          lr.setInitialModel(new 
org.apache.spark.ml.classification.LogisticRegressionModel(
    -            uid, initialWeights.asML, 1.0))
    +          lr.setInitialModel(new 
org.apache.spark.ml.classification.LogisticRegressionModel(uid,
    +            new DenseMatrix(1, initialWeights.size, 
initialWeights.toArray),
    +            Vectors.dense(1.0).asML, 2, false))
    --- End diff --
    
    Maybe we could have another constructor taking the original parameters. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to