Github user dbtsai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14834#discussion_r79507486
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
 ---
    @@ -508,11 +680,51 @@ object LogisticRegression extends 
DefaultParamsReadable[LogisticRegression] {
     @Since("1.4.0")
     class LogisticRegressionModel private[spark] (
         @Since("1.4.0") override val uid: String,
    -    @Since("2.0.0") val coefficients: Vector,
    -    @Since("1.3.0") val intercept: Double)
    +    @Since("2.1.0") val coefficientMatrix: Matrix,
    +    @Since("2.1.0") val interceptVector: Vector,
    +    @Since("1.3.0") override val numClasses: Int,
    --- End diff --
    
    How about we make `numClasses` as a function determined by `isMultinomial` 
and `coefficientMatrix .numRows`. Thus, we can reduce one parameter in the 
constructor. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to