Github user srowen commented on a diff in the pull request:
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
    @@ -580,10 +581,14 @@ class Word2VecModel private[spark] (
           ind += 1
    -    val scored =
    +    val pq = new BoundedPriorityQueue[(String, Double)](num + 
    +    pq ++=
    --- End diff --
    I'm OK to merge this as-is as it is an improvement. I know one of the 
original purposes was to avoid copies. I suppose it's a little more verbose, 
but avoids a collection copy, to do ...
    for (i <- cosVec.indices) {
      pq += (wordList(i), cosVec(i))
    I don't feel strongly about it.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to