Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15139#discussion_r79614619
  
    --- Diff: R/pkg/R/mllib.R ---
    @@ -1398,20 +1398,22 @@ setMethod("summary", signature(object = "KSTest"),
                 distParams <- unlist(callJMethod(jobj, "distParams"))
                 degreesOfFreedom <- callJMethod(jobj, "degreesOfFreedom")
     
    -            list(p.value = pValue, statistic = statistic, nullHypothesis = 
nullHypothesis,
    -                 nullHypothesis.name = distName, nullHypothesis.parameters 
= distParams,
    -                 degreesOfFreedom = degreesOfFreedom)
    +            ans <- list(p.value = pValue, statistic = statistic, 
nullHypothesis = nullHypothesis,
    +                        nullHypothesis.name = distName, 
nullHypothesis.parameters = distParams,
    +                        degreesOfFreedom = degreesOfFreedom, jobj = jobj)
    --- End diff --
    
    Yes, but it's ok to show up. This implementation is a little different from 
others since we would like to reuse the summary information output string which 
was defined at Scala side, otherwise, we should reimplement a same one at R 
side.  We implement the summary information output string at R side directly 
for other wrappers such as ```GLM```, since we do not have appropriate toString 
implementation at Scala side. Maybe later we may unify them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to