Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15131#discussion_r79743521
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -1426,7 +1426,7 @@ class SparkContext(config: SparkConf) extends Logging 
with ExecutorAllocationCli
        * supported for Hadoop-supported filesystems.
        */
       def addFile(path: String, recursive: Boolean): Unit = {
    -    val uri = new URI(path)
    +    val uri = new Path(path).toUri
    --- End diff --
    
    I just check the documentation and tests. It seems Windows paths are being 
tested in 
https://github.com/apache/hadoop/blob/branch-2.7.2/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestPath.java
 as `toString` it based on `URI` instance in `Path` which `toUri` will return 
directly, I guess it'd be safe.
    
    I could not find the explicit mention about Windows path in the 
documenation https://hadoop.apache.org/docs/stable2/api/index.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to