Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/15090
  
    @rxin @wzhfy Just my 2 cents. To address @rxin 's comment, we can implement 
a built-in function, `compute_stats`, like what Hive does. The actual 
implementation of `AnalyzeColumnCommand` can be moved into this function. Then, 
most test cases can be refactored by verifying the correctness of 
`compute_stats`. The testing can be much simplified and the testing coverage 
can be further improved. 
    
    To implement `compute_stats`, we can use the Optimizer rule 
`ReplaceExpressions` to convert it to the actual expressions. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to