Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15140#discussion_r79782388
  
    --- Diff: python/pyspark/context.py ---
    @@ -762,7 +762,7 @@ def accumulator(self, value, accum_param=None):
             SparkContext._next_accum_id += 1
             return Accumulator(SparkContext._next_accum_id - 1, value, 
accum_param)
     
    -    def addFile(self, path):
    +    def addFile(self, path, recursive=False):
    --- End diff --
    
    This basically doesn't change the API right? you can still call it as 
before with the same behavior.
    
    It seems reasonable to me overall because it adds parity between the APIs, 
isn't complex and doesn't change behavior.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to