Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15177#discussion_r79788670
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/linalg/CholeskyDecomposition.scala 
---
    @@ -52,8 +51,20 @@ private[spark] object CholeskyDecomposition {
       def inverse(UAi: Array[Double], k: Int): Array[Double] = {
         val info = new intW(0)
         lapack.dpptri("U", k, UAi, info)
    -    val code = info.`val`
    -    assert(code == 0, s"lapack.dpptri returned $code.")
    +    checkReturnValue(info, "dpptri")
         UAi
       }
    +
    +  private def checkReturnValue(info: intW, method: String): Unit = {
    +    info.`val` match {
    +      case code if code < 0 =>
    +        throw new IllegalStateException(s"LAPACK.$method returned $code; 
arg ${-code} is illegal")
    --- End diff --
    
    Should we output ```arg ${-code}```? Since the arguments is internal used 
and MLlib users have no sense of them and can do nothing to verify it. If the 
arguments of ```dppsv``` is illegal, it should be caused by bugs of MLlib.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to