Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15140#discussion_r79791116
  
    --- Diff: 
core/src/main/scala/org/apache/spark/api/java/JavaSparkContext.scala ---
    @@ -670,6 +670,19 @@ class JavaSparkContext(val sc: SparkContext)
       }
     
       /**
    +   * Add a file to be downloaded with this Spark job on every node.
    +   * The `path` passed can be either a local file, a file in HDFS (or 
other Hadoop-supported
    +   * filesystems), or an HTTP, HTTPS or FTP URI.  To access the file in 
Spark jobs,
    +   * use `SparkFiles.get(fileName)` to find its download location.
    +   *
    +   * A directory can be given if the recursive option is set to true. 
Currently directories are only
    +   * supported for Hadoop-supported filesystems.
    +   */
    +  def addFile(path: String, recursive: Boolean): Unit = {
    --- End diff --
    
    Sounds good. There may be a reason the Java context is needed for some 
calls. I suppose that where the SparkContext could be used ... yeah that's 
simpler but doesn't really save anything because we wouldn't be able to take 
methods out of JavaSparkContext. That's why I was hoping to avoid adding a 
method to it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to