GitHub user HelloCodeMing opened a pull request:
https://github.com/apache/spark/pull/15180
FIX: AggregatedDialect does not quote identifier correctly
## What changes were proposed in this pull request?
If we write an custom MySQL Dialect and register it, it will be fused as an
AggregatedDialect. But AggregatedDialect does not override quoteIdentifier
method, so it will use JDBCDialect's quoteIdentifier method, quote identifier
with ", which is not correct.
## How was this patch tested?
I have manually test this patch. It works as expected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HelloCodeMing/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/15180.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15180
----
commit 7fbd937c50d61530d6c3e06e021f741ccce6eaa3
Author: wanghuanming <wanghuanm...@zhihu.com>
Date: 2016-09-21T10:51:09Z
FIX: AggregatedDialect does not quote identifier correctly
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
