Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14650#discussion_r79892035
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -1962,6 +1962,20 @@ private[spark] object Utils extends Logging {
         path
       }
     
    +  /**
    +   * Updates Spark config with properties from a set of Properties.
    +   * Provided properties have the highest priority.
    +   */
    +  def updateSparkConfigFromProperties(conf: SparkConf, properties: 
Map[String, String])
    +    : Unit = {
    +    properties.filter { case (k, v) =>
    +      k.startsWith("spark.")
    --- End diff --
    
    You can move this to the `foreach` body.
    
    On a side note, this whole method feels a little funny, but I have to see 
how it's used.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to