Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14650#discussion_r79893424
  
    --- Diff: 
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
    @@ -88,6 +82,22 @@ class SparkSubmitSuite
           fail(s"Search string '$searchString' not found in $joined")
         }
       }
    +}
    +
    +// Note: this suite mixes in ResetSystemProperties because 
SparkSubmit.main() sets a bunch
    +// of properties that needed to be cleared after tests.
    +class SparkSubmitSuite
    +  extends SparkFunSuite
    +  with Matchers
    +  with BeforeAndAfterEach
    +  with ResetSystemProperties
    +  with Timeouts
    +  with TestPrematureExit {
    +
    +  override def beforeEach() {
    +    super.beforeEach()
    +    System.setProperty("spark.testing", "true")
    --- End diff --
    
    You shouldn't need to do this. Otherwise it would mean a bug in 
`ResetSystemProperties`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to