Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14079#discussion_r79912771
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
    @@ -51,13 +50,27 @@ import org.apache.spark.util.{AccumulatorV2, 
ThreadUtils, Utils}
      * acquire a lock on us, so we need to make sure that we don't try to lock 
the backend while
      * we are holding a lock on ourselves.
      */
    -private[spark] class TaskSchedulerImpl(
    +private[spark] class TaskSchedulerImpl private[scheduler](
         val sc: SparkContext,
         val maxTaskFailures: Int,
    +    private val blacklistTracker: Option[BlacklistTracker],
         isLocal: Boolean = false)
       extends TaskScheduler with Logging
     {
    -  def this(sc: SparkContext) = this(sc, 
sc.conf.getInt("spark.task.maxFailures", 4))
    +  def this(sc: SparkContext) = {
    +    this(
    +      sc,
    +      sc.conf.getInt("spark.task.maxFailures", 4),
    +      TaskSchedulerImpl.createBlacklistTracker(sc.conf))
    +  }
    +
    +  def this(sc: SparkContext, maxTaskFailures: Int, isLocal: Boolean) = {
    +    this(
    +      sc,
    +      maxTaskFailures,
    +      TaskSchedulerImpl.createBlacklistTracker(sc.conf),
    --- End diff --
    
    you can't have a default param which depends on another param (the `sc` in 
that call).  If you really want, I could make it required, and change all the 
call sites.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to