Github user dilipbiswal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15190#discussion_r79964807
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDDLCommandSuite.scala ---
    @@ -556,4 +558,32 @@ class HiveDDLCommandSuite extends PlanTest {
         assert(partition2.get.apply("c") == "1" && partition2.get.apply("d") 
== "2")
       }
     
    +  test("Test default fileformat") {
    +    withSQLConf("hive.default.fileformat" -> "orc") {
    +      val s1 =
    +        s"""
    +           |CREATE TABLE IF NOT EXISTS fileformat_test (id int)
    +        """.stripMargin
    +      val (desc, exists) = extractTableDesc(s1)
    +      assert(exists)
    +      assert(desc.storage.inputFormat == 
Some("org.apache.hadoop.hive.ql.io.orc.OrcInputFormat"))
    +      assert(desc.storage.outputFormat == 
Some("org.apache.hadoop.hive.ql.io.orc.OrcOutputFormat"))
    +      assert(desc.storage.serde == 
Some("org.apache.hadoop.hive.ql.io.orc.OrcSerde"))
    +    }
    +
    +    withSQLConf("hive.default.fileformat" -> "parquet") {
    +      val s1 =
    +        s"""
    +           |CREATE TABLE IF NOT EXISTS fileformat_test (id int)
    +        """.stripMargin
    +      val (desc, exists) = extractTableDesc(s1)
    --- End diff --
    
    @gatorsmile Thanks !! I have updated as per your comments.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to