Github user yanboliang commented on the issue:

    https://github.com/apache/spark/pull/15113
  
    @BryanCutler Thanks for working on this. I'm a bit worried that if users 
set ```weightCol = None``` for Python means he would like to set ```weightCol = 
null``` for Scala. 
    The common scenario would be:
    ```Scala
    LogisticRegression(maxIter=5, regParam=0.0, weightCol="weight")
    LogisticRegression(maxIter=5, regParam=0.0, weightCol="")    
    LogisticRegression(maxIter=5, regParam=0.0)  
    ```
    And users are unlikely to write the following code:
    ```
    LogisticRegression(maxIter=5, regParam=0.0, weightCol=None)    
    ```
    However, it users actually do this, I'm more likely to consider that he 
will forcibly specify ```weightCol``` as ```null```. So I vote to not change 
this behavior. Thanks.
    cc @srowen @MLnick @jkbradley 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to