Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14698#discussion_r80187168
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
 ---
    @@ -136,7 +136,7 @@ trait ExpressionEvalHelper extends 
GeneratorDrivenPropertyChecks {
         // some expression is reusing variable names across different 
instances.
         // This behavior is tested in ExpressionEvalHelperSuite.
         val plan = generateProject(
    -      GenerateUnsafeProjection.generate(
    +      UnsafeProjection.create(
    --- End diff --
    
    
    >
    + this patch's changes to ObjectExpressionsSuite.scala
    + this patch's changes to ExpressionEvalHelper.scala (this is also critical)
    - this patch's changes to objects.scala
    
    Under this case, the test failed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to