Github user yanboliang commented on a diff in the pull request:
    --- Diff: mllib-local/src/main/scala/org/apache/spark/ml/linalg/BLAS.scala 
    @@ -244,6 +244,15 @@ private[spark] object BLAS extends Serializable {
    +   * y += alpha * A * x
    +   *
    +   * @param A The upper triangular part of A in a [[DenseVector]] (column 
    +   */
    +  def dspmv(n: Int, alpha: Double, A: DenseVector, x: DenseVector, y: 
DenseVector): Unit = {
    --- End diff --
    Yeah, I think developers will check linalg.BLAS to find functions satisfy 
their requirements. The annotation will tell them how these functions can do, 
so they may overlook this function if they need to calculate ```y := alpha*A*x 
+ beta*y```. So I think it's better to use the complete formula.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to