Github user vlad17 commented on a diff in the pull request:
    --- Diff: 
    @@ -223,15 +278,18 @@ private object GBTClassifierSuite extends 
SparkFunSuite {
        * Train 2 models on the given dataset, one using the old API and one 
using the new API.
        * Convert the old model to the new format, compare them, and fail if 
they are not exactly equal.
    +   *
    +   * The old API only supports variance-based impurity, so gbt should have 
that setting.
       def compareAPIs(
           data: RDD[LabeledPoint],
           validationData: Option[RDD[LabeledPoint]],
           gbt: GBTClassifier,
           categoricalFeatures: Map[Int, Int]): Unit = {
    +    assert(gbt.getImpurity == "variance")
    --- End diff --

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to