Github user nchammas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15338#discussion_r83349053
  
    --- Diff: sbin/spark-daemon.sh ---
    @@ -146,13 +176,11 @@ run_command() {
     
       case "$mode" in
         (class)
    -      nohup nice -n "$SPARK_NICENESS" "${SPARK_HOME}"/bin/spark-class 
$command "$@" >> "$log" 2>&1 < /dev/null &
    -      newpid="$!"
    +      execute_command nice -n $SPARK_NICENESS 
${SPARK_HOME}/bin/spark-class $command $@
    --- End diff --
    
    If `SPARK_HOME` contains spaces, this will break. I recommend quoting both 
`SPARK_HOME` and `SPARK_NICENESS` as they were before.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to